Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text formatting mode lost after backspace is used #4423

Merged
merged 8 commits into from
Jan 5, 2022
Merged

Fix text formatting mode lost after backspace is used #4423

merged 8 commits into from
Jan 5, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 3, 2022 •
edited
Loading

Gutenberg PR: WordPress/gutenberg#37676

To test:
Follow the testing instructions from WordPress/gutenberg#37676.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label Jan 3, 2022
@fluiddot fluiddot added this to the 1.69.0 (19.0) milestone Jan 3, 2022
@fluiddot fluiddot self-assigned this Jan 3, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 3, 2022 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot mentioned this pull request Jan 3, 2022
Merged
7 tasks
@fluiddot fluiddot requested review from guarani and antonis January 3, 2022 09:51
@ttahmouch
Copy link
Contributor

ttahmouch commented Jan 4, 2022 •
edited
Loading

Hey, @fluiddot . We will cut the 1.69.0 release on Thursday, January 6, 2022. We plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.69.0.

Question: Should you merge these changes before Thursday, would we be including these changes by simply running the release toolkit again on that date? I'm just trying to make sure I understand the workflow.

It looks like I'm about to ping you a few more times in your other open PRs. :)

@fluiddot
Copy link
Contributor Author

fluiddot commented Jan 4, 2022

Question: Should you merge these changes before Thursday, would we be including these changes by simply running the release toolkit again on that date? I'm just trying to make sure I understand the workflow.

It looks like I'm about to ping you a few more times in your other open PRs. :)

Yep, if I want these changes to be included in 1.69.0, I should merge the PR before you cut the release and run the release script, as it generates the JS bundle (which would include all changes merged by that time) and creates a release branch which will be referenced in the main apps ultimately.

guarani
guarani approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#37676 (review).

@fluiddot fluiddot enabled auto-merge January 5, 2022 14:19
@fluiddot fluiddot merged commit 664889d into develop Jan 5, 2022
@fluiddot fluiddot deleted the fix/text-format-lost-after-backspace branch January 5, 2022 14:32
@geriux geriux mentioned this pull request Jan 5, 2022
Closed
2 tasks
This was referenced Jan 5, 2022
Merged
Merged
@mkevins mkevins mentioned this pull request Jan 7, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

@antonis antonis Awaiting requested review from antonis

Assignees

@fluiddot fluiddot

Labels
[Type] Bug Something isn't working Writing Flow
Projects
None yet
Milestone
1.69.0 (19.0)
Development

Successfully merging this pull request may close these issues.
3 participants
@fluiddot @ttahmouch @guarani